[ 
https://issues.apache.org/jira/browse/TEZ-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672960#comment-15672960
 ] 

Siddharth Seth commented on TEZ-3509:
-------------------------------------

bq. If I understood this correctly-- moved/modified the methods I was using 
from ShuffleUtils in containerLaunchers(s) and DagDeleteRunnable to 
TezCommonUtils and TezRuntimeUtils. Let me know if you have some suggestions or 
changes for this particular move.
Stuff from ShuffleUtils should not be moved to common. Most of it will be logic 
specific to some Shuffle implementation, or some component of the runtime 
library.

Think the second or third patch should be committed to the branch. A separate 
jira can be used to make things pluggable. Don't think the AM is the correct 
place to instantiate the DeletionTracker - given it may handle specific logic.

Haven't got a chance to look at this in as much detail as I would like to. 
Commit v2 or v3, and continue development on the branch?

> Make DAG Deletion path based
> ----------------------------
>
>                 Key: TEZ-3509
>                 URL: https://issues.apache.org/jira/browse/TEZ-3509
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3509.001.patch, TEZ-3509.002.patch, 
> TEZ-3509.003.patch, TEZ-3509.004.patch
>
>
> The idea here is to have the API take a path to delete, be it DAG path today 
> or a vertex level path later on. The current implementation takes a flag 
> which is specific to DAG deletion. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to