[ 
https://issues.apache.org/jira/browse/TEZ-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857380#comment-15857380
 ] 

Harish Jaiprakash commented on TEZ-3609:
----------------------------------------

Yes, the code looks correct for us. Since the type of queries we fire are:
/ws/v1/timeline/TEZ_VERTEX_ID?limit=9007199254740991&primaryFilter=TEZ_DAG_ID%3A%22dag_1486528137069_0001_1%22&_=1486528285235
Here the entityType will be TEZ_VERTEX_ID and primaryFilter name=TEZ_DAG_ID and 
value is dag_1486528137069_0001_1.

We have similar queries to get task details and task attempt details where 
primary filter will be vertex/dag and task/dag. And hence the check that 
entityType is something we know and extract EntityGroupId based on 
primaryFilter.

> Improve ATSv15 performance for DAG entities read calls.
> -------------------------------------------------------
>
>                 Key: TEZ-3609
>                 URL: https://issues.apache.org/jira/browse/TEZ-3609
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: TEZ-3609.01.patch
>
>
> TimelineCachePluginImpl generates TimelineEntityGroupId.newInstance(appId, 
> appId.toString()) as an EntityGroupId for dag entities. This results entities 
> in file based on application EntityGroupId to loaded by ATS during a read 
> operation. This file can become very large in long running AM and causes 
> timeout and delays in ATS.
> Removing this id, reduces this parsing time and prevents the application 
> entities from being loaded into cache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to