[ 
https://issues.apache.org/jira/browse/TEZ-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883859#comment-15883859
 ] 

TezQA commented on TEZ-1526:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12854613/TEZ-1526.6.patch
  against master revision 2158b95.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   
org.apache.tez.runtime.library.cartesianproduct.TestCartesianProductVertexManagerUnpartitioned

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/2277//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2277//console

This message is automatically generated.

> LoadingCache for TezTaskID slow for large jobs
> ----------------------------------------------
>
>                 Key: TEZ-1526
>                 URL: https://issues.apache.org/jira/browse/TEZ-1526
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>              Labels: performance
>         Attachments: 100000-TezTaskIDs.patch, TEZ-1526.3.patch, 
> TEZ-1526.4.patch, TEZ-1526.5.patch, TEZ-1526.6.patch, TEZ-1526-v1.patch, 
> TEZ-1526-v2.patch
>
>
> Using the LoadingCache with default builder settings. 100,000 TezTaskIDs are 
> created in 10 seconds on my setup. With a LoadingCache initialCapacity of 
> 10,000 they are created in 300 ms. With no LoadingCache, they are created in 
> 10 ms. A test case in attached to illustrate the condition I would like to be 
> sped up.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to