[
https://issues.apache.org/jira/browse/TEZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897011#comment-15897011
]
TezQA commented on TEZ-3649:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12856241/TEZ-3649.1.patch
against master revision 1b1eb1d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2300//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2300//console
This message is automatically generated.
> AsyncHttpConnection should add StopWatch start
> ----------------------------------------------
>
> Key: TEZ-3649
> URL: https://issues.apache.org/jira/browse/TEZ-3649
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Fei Hui
> Assignee: Fei Hui
> Fix For: 0.9.0
>
> Attachments: TEZ-3649.1.patch, TEZ-3649.patch
>
>
> {code:title=AsyncHttpConnection.java|borderStyle=solid}
> public void validate() throws IOException {
> // get the shuffle version
> if (!ShuffleHeader.DEFAULT_HTTP_HEADER_NAME
> .equals(response.getHeader(ShuffleHeader.HTTP_HEADER_NAME))
> || !ShuffleHeader.DEFAULT_HTTP_HEADER_VERSION
> .equals(response.getHeader(ShuffleHeader.HTTP_HEADER_VERSION))) {
> throw new IOException("Incompatible shuffle response version");
> }
> // get the replyHash which is HMac of the encHash we sent to the server
> String replyHash =
> response.getHeader(SecureShuffleUtils.HTTP_HEADER_REPLY_URL_HASH);
> if (replyHash == null) {
> throw new IOException("security validation of TT Map output failed");
> }
> LOG.debug("url={};encHash={};replyHash={}", msgToEncode, encHash,
> replyHash);
> // verify that replyHash is HMac of encHash
> SecureShuffleUtils.verifyReply(replyHash, encHash, jobTokenSecretMgr);
> //Following log statement will be used by tez-tool perf-analyzer for
> mapping attempt to NM host
> LOG.info("for url={} sent hash and receievd reply {} ms", url,
> stopWatch.now(TimeUnit.MILLISECONDS));
> }
> {code}
> It uses stopWatch.now, but never starts it. we should start it at the
> beginning of this function
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
