[
https://issues.apache.org/jira/browse/TEZ-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965288#comment-15965288
]
Zhiyuan Yang commented on TEZ-3666:
-----------------------------------
Looks good to me except one nit:
{code}
BigInteger getExpectedStatsInAtIndex(int index) {
{code}
Method name should be getExpectedStatsAtIndex.
Also wondering whether this can be fixed by using long array or doing division
first in
{code}
statsInMB[index] * numTasks / numVMEventsReceived
{code}
> Integer overflow in ShuffleVertexManagerBase
> --------------------------------------------
>
> Key: TEZ-3666
> URL: https://issues.apache.org/jira/browse/TEZ-3666
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: TEZ-3666.patch
>
>
> In function getExpectedStatsInAtIndex, {{statsInMB[index] * numTasks /
> numVMEventsReceived}} could cause Integer overflow, for example when
> statsInMB[index] == 30000 and numTasks == 200000.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
