[ 
https://issues.apache.org/jira/browse/TEZ-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994153#comment-15994153
 ] 

Siddharth Seth commented on TEZ-3700:
-------------------------------------

Sorry for coming in late here.
Nit and rename request: VertexImpl: failedTaskIds - This is really confusing. 
1) it stores taskAttemptIds, but is called TaskIds. 2) VertexImpl already 
tracks TaskIds separately, so why the new parameter? Since this is related to 
obsoletion and InputFailedEvents, I think the parameter needs a rename to 
reflect the same. Also some notes on why this is being done (and tracked 
independently of TaskIds).

Also, the Unordered case with Pipelined Shuffle / Avoid final merge should have 
the same killSelf change ?

> Consumer attempt should kill itself instead of failing during validation 
> checks with final merge avoidance
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3700
>                 URL: https://issues.apache.org/jira/browse/TEZ-3700
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>             Fix For: 0.9.0
>
>         Attachments: TEZ-3700.1.patch, TEZ-3700.2.patch, TEZ-3700.3.patch, 
> TEZ-3700.4.patch, TEZ-3700.5.patch
>
>
> Currently when if data is received from different attempts with final merge 
> disabled (with/without pipleining), consumer attempt ends up with failure. 
> Instead it should issue kill request so that the job deos not end up with 
> failures.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to