[ 
https://issues.apache.org/jira/browse/TEZ-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kuhu Shukla updated TEZ-3705:
-----------------------------
    Attachment: TEZ-3705.006.patch

Thanks [~sseth]. You are right, I have taken out the conf check from 
dagComplete. As for the threadpool initialization, dagComplete() stills looks 
like the right place to initialize it as it saves us the time between the 
Container launchers are initialized and the first dagComplete() is issued to 
not have the threadpool sit around. V6 of the patch follows that idea.

v5 patch initializes the threadpool during construction in case we think its ok 
to have them all set up when dagComplete() is called. This simplifies the 
dagComplete() method but has the drawback of the threadpool init too early.

Appreciate your comments/review on the patch(es)! 



> Modify DeletionTracker and deletion threads to be initialized only if enabled 
> for tez_shuffle
> ---------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3705
>                 URL: https://issues.apache.org/jira/browse/TEZ-3705
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3705.001.patch, TEZ-3705.002.patch, 
> TEZ-3705.003.patch, TEZ-3705.004.patch, TEZ-3705.005.patch, TEZ-3705.006.patch
>
>
> Right now the Deletion Tracker and the associated threads are initialized 
> irrespective of the deletion service being used/enabled or not. This can be 
> made better.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to