[
https://issues.apache.org/jira/browse/TEZ-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming Ma updated TEZ-3666:
-------------------------
Attachment: TEZ-3666-2.patch
Thanks [~aplusplus]! Here is the updated patch to address your comments.
Regarding the second issue, moving division first should cover common
scenarios; but to make sure it doesn't overflow in any case, it is safer to use
BigInteger and check if BigInteger value is greater than Long.MAX_VALUE.
> Integer overflow in ShuffleVertexManagerBase
> --------------------------------------------
>
> Key: TEZ-3666
> URL: https://issues.apache.org/jira/browse/TEZ-3666
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: TEZ-3666-2.patch, TEZ-3666.patch
>
>
> In function getExpectedStatsInAtIndex, {{statsInMB[index] * numTasks /
> numVMEventsReceived}} could cause Integer overflow, for example when
> statsInMB[index] == 30000 and numTasks == 200000.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
