[
https://issues.apache.org/jira/browse/TEZ-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007329#comment-16007329
]
Siddharth Seth commented on TEZ-3721:
-------------------------------------
They're essentially the same approach, with a renamed class?
If you're writing a patch, could you please post one without the rename to make
the review easier. A refactor/rename can happen before commit.
> Extend CallableWithNdc to also clone MDC
> ----------------------------------------
>
> Key: TEZ-3721
> URL: https://issues.apache.org/jira/browse/TEZ-3721
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
>
> CallableWithNdc currently clones only NDC. Hive LLAP uses MDC all over and
> have to implement custom threadpools to copy MDC over to NDC and vice versa
> (with reflection!!) to keep the context around.
> Two possibilities will make this easier
> 1) Keep CallableWithNdc class around and add cloning of MDC
> 2) Add new class CallableWithDiagnosticContext, deprecate CallableWithNdc and
> change all tez code to use CallableWithDiagnosticContext
> 1 is easier as it doesn't change anything. 2 is cleaner wrt to class name but
> little intrusive.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
