[
https://issues.apache.org/jira/browse/TEZ-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuhu Shukla updated TEZ-3729:
-----------------------------
Attachment: TEZ-3729.001.patch
V1 for some comments. Right now its based off of TEZ-3725, TEZ-3726 and
introduces a new Container Launcher class "DagContainerLauncher".
[~jlowe], appreciate any review comments. Thanks a lot!
> Use a new abstract class for ContainerLauncher(s) that provide dagComplete()
> functionality
> ------------------------------------------------------------------------------------------
>
> Key: TEZ-3729
> URL: https://issues.apache.org/jira/browse/TEZ-3729
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Attachments: TEZ-3729.001.patch
>
>
> This JIRA will address the following review comment from [~jlowe].
> {code}
> Does it make sense to create an abstract class in tez-common that derives
> from ContainerLauncher and has an abstract dagComplete method? Then we can
> have the existing launchers derive from that rather than ContainerLauncher
> directly and can RTTI check against that one class rather than maintain a
> specific list of container launchers.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
