[ 
https://issues.apache.org/jira/browse/TEZ-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011601#comment-16011601
 ] 

Siddharth Seth commented on TEZ-3701:
-------------------------------------

For the threading changes, I think this will end up blocking the write method 
if no threads are available, instead of allowing additional buffers to be 
populated, while spills are pending. Could use a regular queue, or stash the 
filled buffers separately, and come back to them for a single spill spanning 
multiple buffers once a thread becomes available. Also, should the number of 
permits be maxThreads, instead of maxThreads-1?

> UnorderedPartitionedKVWriter - issues with parallel Deflater usage, 
> synchronousqueue in threadpool
> --------------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3701
>                 URL: https://issues.apache.org/jira/browse/TEZ-3701
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Harish Jaiprakash
>            Assignee: Rajesh Balamohan
>            Priority: Blocker
>         Attachments: TEZ-3701.2.patch
>
>
> UnorderedPartitionedKVWriter add task to the executor, but does not wait for 
> them to finish before starting the final merge. This can cause finalMerge to 
> fail or write incorrect data.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to