[ 
https://issues.apache.org/jira/browse/TEZ-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011606#comment-16011606
 ] 

Siddharth Seth commented on TEZ-3007:
-------------------------------------

For the SUCCEEDED case, in non-session mode - will it be better to return 
SUCCEEDED, since this actually represents the state of the running dag?
Nit: The fallthrough to SUCCEEDED from FAILED, please add a comment / add a 
break and the condition check again.

Otherwise, looks good.

> Use AppFinalState.ENDED when unregistering with the RM in session mode
> ----------------------------------------------------------------------
>
>                 Key: TEZ-3007
>                 URL: https://issues.apache.org/jira/browse/TEZ-3007
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Harish Jaiprakash
>         Attachments: TEZ-3007.01.patch
>
>
> YARN-4207 adds appFinalState.ENDED. When running in session mode - Tez should 
> make use of this state instead of setting success or failure - since the app 
> final state does not indicate anything about the potentially multiple queries 
> which executed in the app.
> ShimSupport added earlier should facilitate this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to