[
https://issues.apache.org/jira/browse/TEZ-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024911#comment-16024911
]
TezQA commented on TEZ-3741:
----------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12869877/TEZ-3741.001.patch
against master revision a991f17.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.app.TestTaskCommunicatorContextImpl
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2475//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/2475//artifact/patchprocess/newPatchFindbugsWarningstez-runtime-library.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TEZ-Build/2475//artifact/patchprocess/newPatchFindbugsWarningstez-aux-services.html
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2475//console
This message is automatically generated.
> Tez outputs should free memory when closed
> ------------------------------------------
>
> Key: TEZ-3741
> URL: https://issues.apache.org/jira/browse/TEZ-3741
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.7.1, 0.9.0
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: TEZ-3741.001.patch
>
>
> Memory buffers aren't being released as quickly as they could be, e.g.:
> DefaultSorter is holding onto the very large kvbuffer byte array even after
> close() is called, and Ordered and Unordered outputs should remove references
> to sorter and kvWriter in their close.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)