[
https://issues.apache.org/jira/browse/TEZ-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025691#comment-16025691
]
Jonathan Eagles commented on TEZ-3701:
--------------------------------------
Apart from needing a rebase, the patch looks correct for what it is trying to
accomplish. I have some comments and thoughts, though.
* the premise for the more than one thread is that is increases performance.
However, with thread local deflater access and synchronization, I wonder if all
this complication is worth it from a performance standpoint. Do we have any
numbers on this?
* Also there is a deflater leak. End is never called on the thread locals.
> UnorderedPartitionedKVWriter - issues with parallel Deflater usage,
> synchronousqueue in threadpool
> --------------------------------------------------------------------------------------------------
>
> Key: TEZ-3701
> URL: https://issues.apache.org/jira/browse/TEZ-3701
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Harish Jaiprakash
> Assignee: Rajesh Balamohan
> Priority: Blocker
> Attachments: TEZ-3701.2.patch, TEZ-3701.3.patch, TEZ-3701.4.patch,
> TEZ-3701.5.patch
>
>
> UnorderedPartitionedKVWriter add task to the executor, but does not wait for
> them to finish before starting the final merge. This can cause finalMerge to
> fail or write incorrect data.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
