[ 
https://issues.apache.org/jira/browse/TEZ-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031636#comment-16031636
 ] 

Jonathan Eagles commented on TEZ-3713:
--------------------------------------

[~kshukla], the patch looks good. Couple of minor things.
 - 9999 should be nodeId.getPort() in a couple of places()
 - the tests for this patch verify that entries in the map exist before and 
after which is good. Can you file a jira to add a test that verifies correct 
behavior of the deletion tracker. For example, the should be a test that 
verifies that all nodes that are part of a dag are issued a delete command.

> Allow dag level deletion in cases where containers are reused
> -------------------------------------------------------------
>
>                 Key: TEZ-3713
>                 URL: https://issues.apache.org/jira/browse/TEZ-3713
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3713.001.patch, TEZ-3713.002.patch
>
>
> Since we clear the nodeIdtoShufflePortMap after each dagComplete call, it can 
> lead to subsequent dag directories to remain on nodes that end up using the 
> same container for different dags. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to