[
https://issues.apache.org/jira/browse/TEZ-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058242#comment-16058242
]
Jonathan Eagles commented on TEZ-3758:
--------------------------------------
Hey [~kshukla]. Couple of more things I noticed on v3 version of the patch.
{noformat:title=TestTaskImpl}
* failAttempt the spys are not being used and can be taken out
{noformat}
{noformat:title=TaskImpl}
* please group the succeeded and failed state machine transitions again and
reformat to match surrounding code.
* There is a missing status put needed from SUCEEDED under T_ATTEMPT_FAILED. If
the failed event is not for the succeeded attempt we return without marking the
attempt as completed.
{noformat}
> Vertex can hang in RUNNING state when two task attempts finish very closely
> and have retroactive failures
> ---------------------------------------------------------------------------------------------------------
>
> Key: TEZ-3758
> URL: https://issues.apache.org/jira/browse/TEZ-3758
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.7.1, 0.9.0
> Reporter: Kuhu Shukla
> Assignee: Kuhu Shukla
> Attachments: TEZ-3758.001.patch, TEZ-3758.002.patch,
> TEZ-3758.003.patch
>
>
> A vertex's count of what tasks are done can go off in a case where two task
> attempts finish very closely, say within a millisecond of each other. We had
> a case where this task, which was marked successful, never scheduled another
> attempt upon getting a retroactive failure since it thought it had one
> uncompleted task attempt already. This is because the attempt that finished 1
> ms later transitioned to SUCCEEDED but we don't take any action on the
> taskAttempStatus data structure and it stays false. This JIRA will attempt to
> solve that race.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
