[
https://issues.apache.org/jira/browse/TEZ-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061457#comment-16061457
]
Jonathan Eagles commented on TEZ-3274:
--------------------------------------
I think this approach is correct given the comments above regarding making
minimal changes and leaving ShuffleVertexManger as is.
A few minor comments on the code ported from ShuffleVertexManager
{code:title=RootInputVertexManager.java#L68}
public static final float
TEZ_ROOT_INPUT_VERTEX_MANAGER_MIN_SRC_FRACTION_DEFAULT = 0.951f;
public static final float
TEZ_ROOT_INPUT_VERTEX_MANAGER_MAX_SRC_FRACTION_DEFAULT = 0.951f;
{code}
// differs from the ShuffleVertexManager value of 0.25f and 0.75f respectively
{code:title=RootInputVertexManager.java#L231}
public void initialize() {
conf = new Configuration();
{code}
// conf is double initialized here and below. This one can be removed
[~ebadger], there are a number of other style/design comments that are
artifacts of copying the code from the ShuffleVertexManager that should be
cleaned up. I'll file a separate JIRA to address those issues at that time.
> Vertex with MRInput and broadcast input does not respect slow start
> -------------------------------------------------------------------
>
> Key: TEZ-3274
> URL: https://issues.apache.org/jira/browse/TEZ-3274
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Eric Badger
> Attachments: TEZ-3274.001.patch, TEZ-3274.002.patch,
> TEZ-3274.003.patch, TEZ-3274.004.patch
>
>
> Vertices with shuffle input and MRInput choose RootInputVertexManager (and
> not ShuffleVertexManager) and start containers and tasks immediately. In this
> scenario, resources can be wasted since they do not respect
> tez.shuffle-vertex-manager.min-src-fraction
> tez.shuffle-vertex-manager.max-src-fraction.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
