[jira] [Commented] (TEZ-3795) Vertex state machine can throw InvalidStateTransitonException from TERMINATING state

[Jonathan Eagles (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TEZ-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086128#comment-16086128
 ] 

Jonathan Eagles commented on TEZ-3795:
--------------------------------------

[~kshukla]

1) let's add a 5 second timeout to the two tests added.
2) can we replace 

{code}
    int count = 0;
    while (!vertex.inTerminalState() && count < 20) {
      Thread.sleep(100);
      count++;
    }
{code}
{code}
    dispatcher.await();
    Assert.assertTrue(vertex.inTerminalState());
{code}



> Vertex state machine can throw InvalidStateTransitonException from 
> TERMINATING state
> ------------------------------------------------------------------------------------
>
>                 Key: TEZ-3795
>                 URL: https://issues.apache.org/jira/browse/TEZ-3795
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.1, 0.9.0
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: TEZ-3795.001.patch, TEZ-3795.002.patch
>
>
> {code}
> 2017-07-07 14:07:52,976 [ERROR] [Dispatcher thread {Central}] 
> |impl.VertexImpl|: Can't handle Invalid event V_TASK_COMPLETED on vertex 
> scope-463 with vertexId vertex_123_456_1_08 at current state TERMINATING
> org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: 
> V_TASK_COMPLETED at TERMINATING
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:388)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
>         at 
> org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:57)
>         at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.handle(VertexImpl.java:1899)
>         at 
> org.apache.tez.dag.app.dag.impl.VertexImpl.handle(VertexImpl.java:207)
>         at 
> org.apache.tez.dag.app.DAGAppMaster$VertexEventDispatcher.handle(DAGAppMaster.java:2138)
>         at 
> org.apache.tez.dag.app.DAGAppMaster$VertexEventDispatcher.handle(DAGAppMaster.java:2124)
>         at 
> org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:184)
>         at 
> org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115)
>         at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)