[ 
https://issues.apache.org/jira/browse/TEZ-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190021#comment-16190021
 ] 

Jacob Tolar commented on TEZ-3848:
----------------------------------

{quote}
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

I manually tested this with Pig and verified that it symlinks files into place 
and deletes them. I can be more thorough if necessary (e.g. I can try an 
archive also).

I am happy to add tests if needed. Are there any existing tests for 
LocalContainerLauncher?

> Tez Local mode doesn't localize distributed cache files
> -------------------------------------------------------
>
>                 Key: TEZ-3848
>                 URL: https://issues.apache.org/jira/browse/TEZ-3848
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jacob Tolar
>         Attachments: TEZ-3848.1.patch
>
>
> Tez doesn't symlink LocalResources into place in LocalContainerLauncher.
> In YARN mode, Yarn takes care of this when it launches the container. But in 
> local mode, if you're depending on a file existing in the distributed cache, 
> it's never symlinked into place (so you're out of luck).
> We test our pig scripts in local mode and have some tools to set up the 
> distributed cache the same way it would work in production. This works fine 
> in Mapreduce mode but are unable to use Pig + Tez local mode for testing due 
> to this problem.
> I have a fix working and will submit a PR once I rebase it.
> [~jeagles] [[email protected]]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to