[ 
https://issues.apache.org/jira/browse/TEZ-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213469#comment-16213469
 ] 

Zhiyuan Yang commented on TEZ-3856:
-----------------------------------

The logic looks correct, but this api doesn't seem to fit in Vertex interface.
{code}
TezCounters getInputCounters();
{code}

>From interface perspective, Vertex shouldn't be aware of input counters, not 
>to mention some vertices doesn't even have input counter. 

I see you want to extract specific counters instead of full counters. There is 
concept of counter group in original counter framework. In your case a more 
generic API getCounter(groupName) is better. You can group input counters and 
get them by group. This is also useful later when you want to extract other 
specific counters.

> API to access counters in InputInitializerContext
> -------------------------------------------------
>
>                 Key: TEZ-3856
>                 URL: https://issues.apache.org/jira/browse/TEZ-3856
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: TEZ-3856.1.patch
>
>
> Hive would like to publish some counters related to input splits during split 
> generation. Tez doesn't expose TezCounters via InputIntializerContext. This 
> ticket is to expose TezCounters via InputInitializerContext so that counters 
> can be accessed during split generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to