Jason Lowe commented on TEZ-3893:

Thanks for updating the patch!  Looks good overall, only a few nits:

An error should be logged and/or an exception should be thrown if the 
dispatcher receives a message it doesn't understand.

shouldProcess and procesRequest were a bit confusing at first until I 
understood that it only apples to _some_ reqeuests (i.e.: allocation requests). 
 It would be nice if these were renamed to indicate that, e.g.: 
shouldProcessAllocateRequest or canAllocate.

A timeout was removed from a test. Intentional?

> Tez Local Mode can hang for cases
> ---------------------------------
>                 Key: TEZ-3893
>                 URL: https://issues.apache.org/jira/browse/TEZ-3893
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>            Priority: Major
>         Attachments: TEZ-3893.002.patch, TEZ-3893.003.patch, TEZ-3893.1.patch
> The scheduler has a race condition where events that notify can be added 
> while the blocking queue is not waiting, but just before waiting. In this 
> case, we can wait forever.

This message was sent by Atlassian JIRA

Reply via email to