[ 
https://issues.apache.org/jira/browse/TEZ-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389018#comment-16389018
 ] 

Eric Wohlstadter commented on TEZ-3874:
---------------------------------------


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12913265/TEZ-3874.5.patch
  against master revision c34e46c.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/2736//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2736//console

This message is automatically generated.

> NPE in TezClientUtils when "yarn.resourcemanager.zk-address" is present in 
> Configuration
> ----------------------------------------------------------------------------------------
>
>                 Key: TEZ-3874
>                 URL: https://issues.apache.org/jira/browse/TEZ-3874
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1
>            Reporter: Eric Wohlstadter
>            Assignee: Eric Wohlstadter
>            Priority: Blocker
>         Attachments: TEZ-3874.1.patch, TEZ-3874.3.patch, TEZ-3874.4.patch, 
> TEZ-3874.5.patch, TEZ-3874.patch.2
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> "yarn.resourcemanager.zk-address" is deprecated in favor of 
> "hadoop.zk.address" for Hadoop 2.9+.
> Configuration base class does't auto-translate the deprecation. Only 
> YarnConfiguration applies the translation.
> In TezClientUtils.createFinalConfProtoForApp, a NPE is throw if 
> "yarn.resourcemanager.zk-address" is present in the Configuration.
> {code}
> for (Entry<String, String> entry : amConf) {
>       PlanKeyValuePair.Builder kvp = PlanKeyValuePair.newBuilder();
>       kvp.setKey(entry.getKey());
>       kvp.setValue(amConf.get(entry.getKey()));
>       builder.addConfKeyValues(kvp);
>     }
> {code}
> Even though Tez is not specifically looking for the deprecated property, 
> {{amConf.get(entry.getKey())}} will find it during the iteration, if it is in 
> any of the merged xml property resources. 
> {{amConf.get(entry.getKey())}} will return null, and {{kvp.setValue(null)}} 
> will trigger NPE.
> Suggested solution is to change to: 
> {code}
> YarnConfiguration wrappedConf = new YarnConfiguration(amConf);
> for (Entry<String, String> entry : wrappedConf) {
>       PlanKeyValuePair.Builder kvp = PlanKeyValuePair.newBuilder();
>       kvp.setKey(entry.getKey());
>       kvp.setValue(wrappedConf.get(entry.getKey()));
>       builder.addConfKeyValues(kvp);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to