[
https://issues.apache.org/jira/browse/TEZ-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482555#comment-16482555
]
Jason Lowe commented on TEZ-3937:
---------------------------------
Thanks for updating the patch! I think this is a safer change. The unit test
failure is not related, and the test passes locally for me with the patch
applied.
+1 for the latest patch. Committing this.
> Empty partition BitSet to byte[] conversion creates one extra byte in
> rounding error
> ------------------------------------------------------------------------------------
>
> Key: TEZ-3937
> URL: https://issues.apache.org/jira/browse/TEZ-3937
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Priority: Major
> Attachments: TEZ-3937.001.patch, TEZ-3937.002.patch
>
>
> Byte array length calculation is defined as (bitset.length / 8) + 1 which has
> off by one errors on byte boundaries. For example, BitSet of length 0 is
> converted to a byte array of length 1. This was introduced as part of TEZ-972
> since BitSet.toByteArray and valueOf were not supported as Tez supported Java
> 6 at the time and API was introduced in Java 7.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
