[ 
https://issues.apache.org/jira/browse/TEZ-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486664#comment-16486664
 ] 

TezQA commented on TEZ-3939:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12924674/TEZ-3939.001.patch
  against master revision bf87a0f.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.test.TestSecureShuffle

                                      The following test timeouts occurred in :
 org.apache.tez.tests.TestExternalTezServicesErrors
org.apache.tez.tests.TestExternalTezServices

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/2808//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2808//console

This message is automatically generated.


> Remove performance hit of precondition check in AM for register running task 
> attempt
> ------------------------------------------------------------------------------------
>
>                 Key: TEZ-3939
>                 URL: https://issues.apache.org/jira/browse/TEZ-3939
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>            Priority: Major
>         Attachments: TEZ-3939.001.patch
>
>
> {noformat}
>    java.lang.Thread.State: RUNNABLE
>         at org.apache.tez.dag.records.TezTaskID.appendTo(TezTaskID.java:118)
>         at 
> org.apache.tez.dag.records.TezTaskAttemptID.appendTo(TezTaskAttemptID.java:97)
>         at 
> org.apache.tez.dag.records.TezTaskAttemptID.toString(TezTaskAttemptID.java:119)
>         at java.lang.String.valueOf(String.java:2994)
>         at java.lang.StringBuilder.append(StringBuilder.java:131)
>         at 
> org.apache.tez.dag.app.TezTaskCommunicatorImpl.registerRunningTaskAttempt(TezTaskCommunicatorImpl.java:225)
>         at 
> org.apache.tez.dag.app.TaskCommunicatorWrapper.registerRunningTaskAttempt(TaskCommunicatorWrapper.java:56)
>         at 
> org.apache.tez.dag.app.TaskCommunicatorManager.registerTaskAttempt(TaskCommunicatorManager.java:565)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerImpl.registerAttemptWithListener(AMContainerImpl.java:1184)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerImpl$AssignTaskAttemptTransition.transition(AMContainerImpl.java:656)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerImpl$AssignTaskAttemptTransition.transition(AMContainerImpl.java:595)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:385)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
>         at 
> org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
>         - locked <0x000000079b9161f8> (a 
> org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine)
>         at 
> org.apache.tez.state.StateMachineTez.doTransition(StateMachineTez.java:59)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerImpl.handle(AMContainerImpl.java:441)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerImpl.handle(AMContainerImpl.java:78)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerMap.handle(AMContainerMap.java:68)
>         at 
> org.apache.tez.dag.app.rm.container.AMContainerMap.handle(AMContainerMap.java:40)
>         at 
> org.apache.tez.common.AsyncDispatcher.dispatch(AsyncDispatcher.java:180)
>         at 
> org.apache.tez.common.AsyncDispatcher$1.run(AsyncDispatcher.java:115)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to