[
https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Lowe reassigned TEZ-3964:
-------------------------------
Assignee: Jaume M
Thanks for the report and patch!
Looks good overall. I think it would be prudent to wrap the code in
convertDAGPlanToATSMap in a try..finally block for future maintenance. The
signature already declares it can throw IOException, so if someone adds some
code that does throw and forgets to handle the inflater.end call the bug will
reappear. I'd recommend refactoring the body into a private method that takes
an Inflater argument rather than indenting the whole body with the patch --
it's already a really long method.
> Inflater not closed in some places
> ----------------------------------
>
> Key: TEZ-3964
> URL: https://issues.apache.org/jira/browse/TEZ-3964
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.9.1
> Reporter: Jaume M
> Assignee: Jaume M
> Priority: Major
>
> We call [this
> method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363]
> from a few places. We don't call {{end()}} from most of the place where we
> call and although it's not necessary to call it explicitly it's the
> recommended way in the docs to do so.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
