[ https://issues.apache.org/jira/browse/TEZ-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534215#comment-16534215 ]
Jaume M commented on TEZ-3964: ------------------------------ Thank you for reviewing [~jlowe]. Looks like the method doesn't throw {{IOException}} despite being declared in the method. Maybe we can remove the {{throws IOException}} from the declaration. We can still do the refactor you mentioned in case some returns early in the future. > Inflater not closed in some places > ---------------------------------- > > Key: TEZ-3964 > URL: https://issues.apache.org/jira/browse/TEZ-3964 > Project: Apache Tez > Issue Type: Bug > Affects Versions: 0.9.1 > Reporter: Jaume M > Assignee: Jaume M > Priority: Major > > We call [this > method|https://github.com/apache/tez/blob/314dfc79b4b3f528b680b4fee73ad0dca3a3a19b/tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java#L363] > from a few places. We don't call {{end()}} from most of the place where we > call and although it's not necessary to call it explicitly it's the > recommended way in the docs to do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)