[ 
https://issues.apache.org/jira/browse/TEZ-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535358#comment-16535358
 ] 

ASF GitHub Bot commented on TEZ-3958:
-------------------------------------

Github user beltran commented on the issue:

    https://github.com/apache/tez/pull/23
  
    As @ewohlstad pointed out there was a comma after the priority. This is how 
it looks now:
    ```
    digraph INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_ {
    graph [ label="INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_", fontsize=24, 
fontname=Helvetica];
    node [fontsize=12, fontname=Helvetica];
    edge [fontsize=9, fontcolor=blue, fontname=Arial];
    "INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1__dummy_table" [ label = 
"Map_1[_dummy_table]", shape = "box" , color= "black"];
    "INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1__dummy_table" -> 
"INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1" [ label = "Input 
[inputClass=MRInputLegacy,\n initializer=MRInputAMSplitGenerator]" ];
    "INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1" [ label = 
"Map_1[MapTezProcessor,\n priority=2]" , color= "black" ];
    "INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1" -> 
"INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1_out_Map_1" [ label = 
"Output [outputClass=MROutput,\n committer=]" ];
    "INSERT_INTO_ntest_id_age_VALUES_1_1_Stage_1_.Map_1_out_Map_1" [ label = 
"Map_1[out_Map_1]", shape = "box" , color= "black"];
    }
    ```


> Add internal vertex priority information into the tez dag.dot debug 
> information
> -------------------------------------------------------------------------------
>
>                 Key: TEZ-3958
>                 URL: https://issues.apache.org/jira/browse/TEZ-3958
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Gopal V
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3958.1.patch, TEZ-3958.2.patch
>
>
> Adding the actual vertex priority as computed by Tez into the debug dag.dot 
> file would allows the debugging of task pre-emption issues when the DAG is no 
> longer a tree.
> There are pre-emption issues with isomerization of Tez DAGs, where the a 
> R-isomer dag with mirror rotation runs at a different speed than the L-isomer 
> dag, due to priorities at the same level changing due to the vertex-id order.
> Since the problem is hard to debug through, it would be good to record the 
> computed priority in the DAG .dot file in the logging directories.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to