[ 
https://issues.apache.org/jira/browse/TEZ-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558435#comment-16558435
 ] 

Nishant Dash commented on TEZ-3934:
-----------------------------------

No extra tests were included as a small design change was made. Initially, 
tests like TestBasicSpeculation would fail every once so often, and can me made 
to fail more often and always if certain parameters such as 
soonestRetryAfterNoSpeculate were set low enough (TEZ-3952 would allow a user 
to do so). The patch makes design changes that eliminate the race that could 
occur due to for example, high network latency. With the patch, the test will 
always pass.

> LegacySpeculator sometime issues wrong number of speculative attempts
> ---------------------------------------------------------------------
>
>                 Key: TEZ-3934
>                 URL: https://issues.apache.org/jira/browse/TEZ-3934
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Nishant Dash
>            Priority: Major
>         Attachments: TEZ-3934.001.patch, TEZ-3934.002.patch, 
> TEZ-3934.003.patch, TEZ-3934.003.patch, TestSpeculation-output.txt
>
>
> Attaching a log from TestSpeculation that shows two speculative events 
> launched instead of just a single one. I have seen this in practice and not 
> just in tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to