[
https://issues.apache.org/jira/browse/TEZ-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969884#comment-16969884
]
Gopal Vijayaraghavan commented on TEZ-4096:
-------------------------------------------
LGTM - +1 on the new change.
Also
{code}
- keystoresFactory = ReflectionUtils.newInstance(klass, sslConf);
-
+ keystoresFactory = ReflectionUtils.newInstance(klass, conf);
{code}
looks to be an actual fix for an unreported bug (i.e local configs not matching
wire configs from AM).
> SSLFactory should make an attempt to add ssl config resources as "Path"
> -----------------------------------------------------------------------
>
> Key: TEZ-4096
> URL: https://issues.apache.org/jira/browse/TEZ-4096
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Priority: Major
> Attachments: TEZ-4096.1.patch, TEZ-4096.2.patch, TEZ-4096.3.patch
>
>
> SSLFactory uses "String" instead of "Path" for adding "ssl-client.xml". When
> addResource is invoked with string, {{Configuration}} tries to find it in
> classloader and does not load the file correctly.
> [https://github.com/apache/tez/blob/master/tez-runtime-library/src/main/java/org/apache/tez/http/SSLFactory.java#L107]
> Conf:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L3064]
> This creates issue when ssl-client.xml is located in different path other
> than the classpath.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
