[ 
https://issues.apache.org/jira/browse/TEZ-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085697#comment-17085697
 ] 

László Bodor commented on TEZ-4144:
-----------------------------------

reduced NoWhiteSpaceAfter warning from 313 to 8

{code}
mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true | tee 
checkstyle_before.txt
 grep NoWhitespaceAfter checkstyle_before.txt| wc -l
     313
#apply patch
mvn clean install -DskipTests -pl tez-build-tools
mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true | tee 
checkstyle_after.txt
 grep NoWhitespaceAfter checkstyle_before.txt| wc -l
     8
{code}

basically I added [default token value 
|https://checkstyle.sourceforge.io/config_whitespace.html#NoWhitespaceAfter] of 
NoWhitespaceAfter module and removed ARRAY_INIT, ARRAY_DECLARATOR from it  

> Checkstyle: '{' is followed by whitespace
> -----------------------------------------
>
>                 Key: TEZ-4144
>                 URL: https://issues.apache.org/jira/browse/TEZ-4144
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Trivial
>         Attachments: TEZ-4114.01.patch, checkstyle_after.txt, 
> checkstyle_before.txt
>
>
> Precommit checkstyle result always complains about this one:
> {code}
> ./tez-tools/analyzers/job-analyzer/src/main/java/org/apache/tez/analyzer/plugins/TaskAttemptResultStatisticsAnalyzer.java:46:
>       { "vertex (+task stats: all/succeeded/failed/killed)", "node", 
> "status", "numAttempts" };:7: '{' is followed by whitespace. 
> [NoWhitespaceAfter]
> {code}
> is really an issue?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to