[ 
https://issues.apache.org/jira/browse/TEZ-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101599#comment-17101599
 ] 

László Bodor commented on TEZ-4169:
-----------------------------------

TestRecovery times out, but it also times out on master...
[~ashutoshc], [~jeagles]: could you please take a look at this patch?
the patch removed all compile scope jackson dependencies except the one which 
is really used in tez-protobuf-history-plugin, so with this, I'm expecting a 
cleaner dependency tree in terms of jackson (which is subject of 
vulnerabilities from time to time btw...)

{code}
mvn dependency:tree | grep jackson

[INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:test
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:test
[INFO] |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:test
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:test
[INFO] |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:test
[INFO] |  \- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:test
[INFO] |  +- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:test
[INFO] |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:test
[INFO] |  |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:test
[INFO] |  +- 
com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.7.8:test
[INFO] |  \- 
com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.7.8:test
[INFO] |     \- com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.7.8:test
[INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:test
[INFO] |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.7.0:test
[INFO] |  \- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:test
[INFO] +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.2:compile
[INFO] |  \- org.codehaus.jackson:jackson-core-asl:jar:1.9.2:compile
[INFO] |  |  +- 
com.fasterxml.jackson.core:jackson-annotations:jar:2.7.8:provided
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.7.8:test
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.7.8:test
{code}

> Remove unused transitive compile time jackson dependencies
> ----------------------------------------------------------
>
>                 Key: TEZ-4169
>                 URL: https://issues.apache.org/jira/browse/TEZ-4169
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4169.01.patch, TEZ-4169.02.patch, TEZ-4169.03.patch, 
> TEZ-4169.04.patch, TEZ-4169.05.patch
>
>
> Tez has many occurrences of jackson dependencies in its dep tree, however 
> none of them is direct:
> {code}
>  lbodor@HW12459  ~/apache/tez   master  mvn dependency:tree | grep 
> jackson | wc -l
>      204
> {code}
> This is misleading, because tez protobuf history plugin does depend on 
> jackson mapper, so it should have jackson as a direct dependency.
> Similarly to other dependencies, transitive deps can also trigger security 
> scan alerts, complaining about outdated jackson dependencies. It would be 
> cleaner to:
> 1. completely remove unused transitive jackson depdendencies and re-add them 
> in test scope where it's needed for clarity's sake
> 2. include jackson as direct dependency where it's used (this could move 
> focus to that place when there is a need for an upgrade)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to