[
https://issues.apache.org/jira/browse/TEZ-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117492#comment-17117492
]
TezQA commented on TEZ-4185:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 9m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
57s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
55s{color} | {color:red} tez-runtime-library in master has 1 extant findbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 16s{color} | {color:orange} tez-runtime-library: The patch generated 5 new +
182 unchanged - 1 fixed = 187 total (was 183) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 11s{color}
| {color:red} tez-runtime-library in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.9 Server=19.03.9 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/450/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4185 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13004101/TEZ-4185.2.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux 1d117f3e5ef0 4.15.0-101-generic #102-Ubuntu SMP Mon May 11
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 0411a2e |
| Default Java | 1.8.0_252 |
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/450/artifact/out/branch-findbugs-tez-runtime-library-warnings.html
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/450/artifact/out/diff-checkstyle-tez-runtime-library.txt
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/450/artifact/out/patch-unit-tez-runtime-library.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/450/testReport/ |
| Max. process+thread count | 126 (vs. ulimit of 5500) |
| modules | C: tez-runtime-library U: tez-runtime-library |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/450/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Tez may skip file permission update on intermediate output
> ----------------------------------------------------------
>
> Key: TEZ-4185
> URL: https://issues.apache.org/jira/browse/TEZ-4185
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.10.1, 0.9.3
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Attachments: TEZ-4185.1.patch, TEZ-4185.2.patch
>
>
> Before updating file permissions TEZ check if the permission change is needed
> with the following conditional:
> {code:java}
> if
> (!SPILL_FILE_PERMS.equals(SPILL_FILE_PERMS.applyUMask(FsPermission.getUMask(conf))))
> {
> rfs.setPermission(filename, SPILL_FILE_PERMS);
> } {code}
> The problem is that the config object used by this conditional can be
> different than the config used by the file system (rfs). The reason for this
> is the underlaying file system instance cache in hadoop.
> Either we should remove this conditional altogether (it's a local file
> system, it won't generate NN calls) or modify it to use rfs.getConf().
> The end result is a file, which is not readable by the group, because the
> permission change was skipped due to the umask mismatch between the 2 configs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
