[
https://issues.apache.org/jira/browse/TEZ-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121466#comment-17121466
]
TezQA commented on TEZ-4192:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
39s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
18s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
18s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
12s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color}
| {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 12s{color}
| {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 22s{color} | {color:orange} tez-dag: The patch generated 9 new + 206
unchanged - 2 fixed = 215 total (was 208) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 9s{color} | {color:orange} tez-ext-service-tests: The patch generated 3 new
+ 11 unchanged - 0 fixed = 14 total (was 11) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
19s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
45s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 19s{color}
| {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s{color}
| {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.11 Server=19.03.11 base:
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4192 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13004527/TEZ-4192.1.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux bd5b385480b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 28cf7dc |
| Default Java | 1.8.0_252 |
| mvninstall |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-mvninstall-tez-dag.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-mvninstall-tez-ext-service-tests.txt
|
| compile |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-compile-tez-dag.txt
|
| compile |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-compile-tez-ext-service-tests.txt
|
| javac |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-compile-tez-dag.txt
|
| javac |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-compile-tez-ext-service-tests.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/diff-checkstyle-tez-dag.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/diff-checkstyle-tez-ext-service-tests.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-findbugs-tez-dag.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-findbugs-tez-ext-service-tests.txt
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-unit-tez-dag.txt
|
| unit |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/artifact/out/patch-unit-tez-ext-service-tests.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/testReport/ |
| Max. process+thread count | 258 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-ext-service-tests U: . |
| Console output |
https://builds.apache.org/job/PreCommit-TEZ-Build/458/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
> Attach task specific info in scheduler and retrieve in communicator
> -------------------------------------------------------------------
>
> Key: TEZ-4192
> URL: https://issues.apache.org/jira/browse/TEZ-4192
> Project: Apache Tez
> Issue Type: Improvement
> Affects Versions: 0.9.2
> Reporter: Mustafa Iman
> Assignee: Mustafa Iman
> Priority: Major
> Attachments: TEZ-4192.1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is no way to pass information from scheduler to communicator. Sometimes
> we want to let communicator know about extra properties of the task other
> than its spec. One example is if a task is preemptable.
> When scheduler receives a task, its taskspec is already constructed. It is a
> nice immutable object at this point. We do not want to modify and put more
> info in it at that stage. So we pass a new piece of information to
> TaskSchedulerContext#taskAllocated along with the allocation. This info is
> passed to the communicator untouched. It is up to the communicator
> implementation to make use of it. Communicator implementation needs to
> override a new registerRunningTaskAttempt that accepts this additional object
> along with all the other arguments in the original registerRunningTaskAttempt
> method.
> The new registerRunningTaskAttempt method has a default implementation that
> falls back to the old method. So if the user does not override the new
> method, the same old behavior is preserved. Similarly on scheduler side, the
> user needs to call new taskAllocated method to pass the additional info
> object. If they use the old taskAllocated method, old behavior is preserved.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
