[ 
https://issues.apache.org/jira/browse/TEZ-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161819#comment-17161819
 ] 

László Bodor commented on TEZ-4196:
-----------------------------------

[~pvary]: thanks for the patch, I can understand the purpose of this fix

according to your internal conversation [~rbalamohan], this indeed opens an API 
where an incorrect YarnConfiguration can be passed by the user...however, the 
getClient API (introduced in TEZ-3892) already assumes the user is aware what's 
going on with already running AM's (I know this is not a 100% valid explanation)

before merging this particular patch, please let's consider taking a look at 
TEZ-4175, as it also eliminates the overhead which is supposed to be eliminated 
by this patch (right?):
{code}
amConfig.setYarnConfiguration(new 
YarnConfiguration(amConfig.getTezConfiguration()));
{code}

> Add a possibility to provide configuration when creating TezClient
> ------------------------------------------------------------------
>
>                 Key: TEZ-4196
>                 URL: https://issues.apache.org/jira/browse/TEZ-4196
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Priority: Major
>         Attachments: TEZ-4196.01.patch, TEZ-4196.02.patch
>
>
> Currently Tez/YarnConfiguration creation is not too flexible.
> It would be good to have a possibility to provide YarnConfiguration from 
> outside, and also making sure that when a TezConfiguration is created it 
> should not parse the files again.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to