[ 
https://issues.apache.org/jira/browse/TEZ-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172763#comment-17172763
 ] 

Rajesh Balamohan commented on TEZ-3645:
---------------------------------------

[~jeagles]: May have to rebase the patch for latest codebase (minor import 
needed in TestIFile).

 

In MergeManager, key, value classes can be obtained in constructor instead of 
merge() methods.

 

Rest LGTM. +1.

> Reuse SerializationFactory while sorting, merging, and writing IFiles 
> ----------------------------------------------------------------------
>
>                 Key: TEZ-3645
>                 URL: https://issues.apache.org/jira/browse/TEZ-3645
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Turner Eagles
>            Assignee: Jonathan Turner Eagles
>            Priority: Major
>         Attachments: TEZ-3645.003.patch, TEZ-3645.1.patch, TEZ-3645.2.patch
>
>
> Of course this is not reusing the serializer, just the SerializationFactory 
> and Serialization. They are jointly responsible for iterating over the list 
> of available serializers and finding an acceptable one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to