[
https://issues.apache.org/jira/browse/TEZ-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224272#comment-17224272
]
László Bodor edited comment on TEZ-4215 at 11/1/20, 4:25 PM:
-------------------------------------------------------------
this warning is indeed annoying, as guava27 has @Nullable annotation in the
called methods' signature (both Strings.isNullOrEmpty and Functions.forMap)
this is similar to HADOOP-16210, where it was solved by findbugs exclude, I'm
afraid that's the only possible solution at the moment here too, attached
[^TEZ-4215.01.patch]
tested by:
{code}
mvn findbugs:findbugs -DskipTests=true -pl ./tez-tools/analyzers/job-analyzer/
# check ./tez-tools/analyzers/job-analyzer/target/findbugsXml.xml
{code}
was (Author: abstractdog):
this warning is indeed annoying, as guava27 has @Nullable annotation in the
called methods' signature (both Strings.isNullOrEmpty and Functions.forMap)
this is similar to HADOOP-16210, where it was solved by findbugs exclude, I'm
afraid that's the only possible solution at the moment here too, attached
[^TEZ-4215.01.patch]
> Address findbugs warnings in analyzers
> --------------------------------------
>
> Key: TEZ-4215
> URL: https://issues.apache.org/jira/browse/TEZ-4215
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jonathan Turner Eagles
> Assignee: Jonathan Turner Eagles
> Priority: Major
> Attachments: TEZ-4215.01.patch, TEZ-4215.WIP.patch
>
>
> {code}
> NP Null passed for non-null parameter of
> com.google.common.base.Strings.isNullOrEmpty(String) in
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 576]
> NP Null passed for non-null parameter of
> com.google.common.base.Strings.isNullOrEmpty(String) in
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 519]
> NP Null passed for non-null parameter of
> com.google.common.base.Strings.isNullOrEmpty(String) in
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Bug type NP_NULL_PARAM_DEREF (click for details)
> In class org.apache.tez.analyzer.plugins.CriticalPathAnalyzer
> In method
> org.apache.tez.analyzer.plugins.CriticalPathAnalyzer.createCriticalPath(DagInfo,
> TaskAttemptInfo, long, Map)
> Called method com.google.common.base.Strings.isNullOrEmpty(String)
> Argument 1 might be null but must not be null
> Value loaded from nextAttemptId
> Method invoked at CriticalPathAnalyzer.java:[line 588]
> Known null at CriticalPathAnalyzer.java:[line 532]
> NP Null passed for non-null parameter of
> com.google.common.base.Functions.forMap(Map, Object) in
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Bug type NP_NONNULL_PARAM_VIOLATION (click for details)
> In class org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer
> In method
> org.apache.tez.analyzer.plugins.VertexLevelCriticalPathAnalyzer.sortByValues(Map)
> Called method com.google.common.base.Functions.forMap(Map, Object)
> Argument 2 is definitely null but must not be null
> At VertexLevelCriticalPathAnalyzer.java:[line 116]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
