[ 
https://issues.apache.org/jira/browse/TEZ-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259063#comment-17259063
 ] 

Rajkumar Singh commented on TEZ-4254:
-------------------------------------

Hi [~amagyar], Thanks for looking into it.

with both mapreduce.shuffle.ssl.enabled and tez.runtime.shuffle.ssl.enable set 
to true we unset the value and dont set it correctly because both of these 
conditions are evaluated false 
https://github.com/apache/tez/blob/master/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRHelpers.java#L188-L192
 and tez.runtime.shuffle.ssl.enable just have a place holder with  variable 
substitution (tez.runtime.shuffle.ssl.enable={mapreduce.shuffle.ssl.enabled})

with this change if both mr and tez equivalents has same config value then it 
does set value correctly for tez config.

> Don't unset the tez config if both mr and tez config have same value.
> ---------------------------------------------------------------------
>
>                 Key: TEZ-4254
>                 URL: https://issues.apache.org/jira/browse/TEZ-4254
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1
>            Reporter: Rajkumar Singh
>            Priority: Major
>         Attachments: TEZ-4254.patch
>
>
> while translated mr config to the tez config we unset config here.
> https://github.com/apache/tez/blob/master/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRHelpers.java#L187
> There is no need to unset the config if both mr and tez have same value.
> we observed if equivalent of tez config for mapreduce.shuffle.ssl.enabled 
> (tez.runtime.shuffle.ssl.enable) set to true, we unset the config, this 
> propagate config 
> tez.runtime.shuffle.ssl.enable={mapreduce.shuffle.ssl.enabled} at runtime and 
> variable substitution does not work correctly in the absence of mrconfig 
> runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to