[ 
https://issues.apache.org/jira/browse/TEZ-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283756#comment-17283756
 ] 

Tez CI commented on TEZ-4290:
-----------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  7m 
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} hadolint {color} | {color:green}  0m  
3s{color} | {color:green} There were no new hadolint issues. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  1m 
 1s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  9m 18s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-111/2/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/tez/pull/111 |
| JIRA Issue | TEZ-4290 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs |
| uname | Linux 2aa9b06a1708 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / a42e1700e |
| Max. process+thread count | 46 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-111/2/console |
| versions | git=2.25.1 maven=3.6.3 shellcheck=0.7.1 hadolint=1.18.0-0-g76eee5c 
|
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Dockerfile improvements
> -----------------------
>
>                 Key: TEZ-4290
>                 URL: https://issues.apache.org/jira/browse/TEZ-4290
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>             Fix For: 0.10.1, 0.9.3
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Given these improvement ideas: 
> https://github.com/aw-was-here/tez/commit/bead3a21e68ecf4a75d64d8c08b9f8fa0f98cf51
> thanks  [~aw]
> Dockerfile changes could be easily tested, becuase it can be build locally 
> (as discovered on TEZ-4283):
> {code}
> docker build -f ./build-tools/docker/Dockerfile ./build-tools/docker/
> {code}
> Moreover, it's applied on PR level, so a full precommit test (including all 
> modules) could let us validate the correctness of the image changes.
> So, I'm suspecting that Dockerfile changes can come in advance, before 
> introducing Jenkinsfile, which is a bit harder to test (I guess).
> according to [~aw]'s comments:
> {code}
>   - Update to an image that won't be unsupported in a year
>   - Remove a bunch of stuff that Tez doesn't use
>   - Add support for a bunch of stuff that Yetus needs to test everything 
> (however, keeping FindBugs over SpotBugs)
>   - Make it Docker BuildKit compatible to make it build in parallel
>   - Support both OpenJDK 8 and OpenJDK 11
>   - Switch to python3 because python2 is effectively dead in January with pip 
> changes
>   - Remove the interactive bits of the Dockerfile since nothing appears to be 
> using them
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to