abstractdog commented on a change in pull request #157:
URL: https://github.com/apache/tez/pull/157#discussion_r740374677
##########
File path:
tez-dag/src/main/java/org/apache/tez/dag/api/client/DAGStatusBuilder.java
##########
@@ -61,6 +61,13 @@ public void addVertexProgress(String name, ProgressBuilder
progress) {
getBuilder().addVertexProgress(builder.build());
}
+ //TODO: let this be a map of values in protobuf 3.x
Review comment:
I wanted to put these memory related stuff into a map, which can be
dinamically extended later with other metrics if needed, but unfortunately the
protoc compiler which is used in protobuf 2.5 doesn't support maps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
