belugabehr commented on pull request #172: URL: https://github.com/apache/tez/pull/172#issuecomment-1002853340
@jteagles I create a small driver with JMH: ``` Benchmark Mode Cnt Score Error Units TestSplit.master thrpt 30 5324642.492 ± 228078.761 ops/s TestSplit.tez4365 thrpt 30 1809324.533 ± 37792.272 ops/s ``` Quite a bit slower, but still an impressive 1,809,324 string per second on my dated hardware. Using regex provides for fewer lines of code and makes it more readable. But your call. If you're not accepting of it, consider the unit tests update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
