abstractdog commented on a change in pull request #72:
URL: https://github.com/apache/tez/pull/72#discussion_r783132898
##########
File path:
tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java
##########
@@ -1421,14 +1462,14 @@ protected ChannelFuture
sendMapOutput(ChannelHandlerContext ctx, Channel ch,
}
ChannelFuture writeFuture;
if (ch.pipeline().get(SslHandler.class) == null) {
- final FadvisedFileRegion partition = new FadvisedFileRegion(spill,
+ final org.apache.tez.auxservices.FadvisedFileRegion partition = new
org.apache.tez.auxservices.FadvisedFileRegion(spill,
Review comment:
I don't think a fully qualified class name is needed here, as
FadvisedFileRegion is in the same package
##########
File path:
tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java
##########
@@ -1421,14 +1462,14 @@ protected ChannelFuture
sendMapOutput(ChannelHandlerContext ctx, Channel ch,
}
ChannelFuture writeFuture;
if (ch.pipeline().get(SslHandler.class) == null) {
- final FadvisedFileRegion partition = new FadvisedFileRegion(spill,
+ final org.apache.tez.auxservices.FadvisedFileRegion partition = new
org.apache.tez.auxservices.FadvisedFileRegion(spill,
rangeOffset, rangePartLength, manageOsCache, readaheadLength,
readaheadPool, spillFile.getAbsolutePath(),
shuffleBufferSize, shuffleTransferToAllowed);
writeFuture = ch.write(partition);
} else {
// HTTPS cannot be done with zero copy.
- final FadvisedChunkedFile chunk = new FadvisedChunkedFile(spill,
+ final org.apache.tez.auxservices.FadvisedChunkedFile chunk = new
org.apache.tez.auxservices.FadvisedChunkedFile(spill,
Review comment:
same here as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
