abstractdog commented on a change in pull request #187:
URL: https://github.com/apache/tez/pull/187#discussion_r809811432
##########
File path: tez-tools/pom.xml
##########
@@ -50,6 +50,25 @@
<module>tez-tfile-parser</module>
</modules>
</profile>
+ <profile>
+ <id>jdk1.8</id>
+ <activation>
+ <jdk>1.8</jdk>
+ </activation>
+ <modules>
+ <module>tez-javadoc-tools-base-jdk8</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9plus</id>
+ <activation>
+ <!-- JDK9 starts strong encapsulation of Java internals, JDK17
removes/hides those -->
+ <jdk>[9,9999)</jdk>
Review comment:
which version does this expression target?
if every version starting with "9", then a simply "9" should work
https://maven.apache.org/guides/introduction/introduction-to-profiles.html
```
The following configuration will trigger the profile when the JDK's version
starts with "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"):
<profiles>
<profile>
<activation>
<jdk>1.4</jdk>
</activation>
...
</profile>
</profiles>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
