LA-Toth commented on a change in pull request #190:
URL: https://github.com/apache/tez/pull/190#discussion_r809872181
##########
File path:
tez-dag/src/test/java/org/apache/tez/dag/app/dag/impl/TestVertexManager.java
##########
@@ -24,14 +24,8 @@
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-import static org.mockito.Matchers.any;
-import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.*;
Review comment:
Cool, OK, consistency is also important for me.
But the tests don't always do that, namely the `any()` and the other
matchers can be imported both as `org.mockito.Mockito.any` and as
`org.mockito.ArgumentMatchers.any`. I would keep only one of these. The
`org.mockito.Mockito.any` seems to be the better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
