abstractdog commented on a change in pull request #60:
URL: https://github.com/apache/tez/pull/60#discussion_r825298428
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
##########
@@ -1772,6 +1773,17 @@ private static void parseVertexEdges(DAGImpl dag,
Map<String, EdgePlan> edgePlan
vertex.setInputVertices(inVertices);
vertex.setOutputVertices(outVertices);
+ boolean cleanupShuffleDataAtVertexLevel =
dag.dagConf.getInt(TezConfiguration.TEZ_AM_VERTEX_CLEANUP_HEIGHT,
+ TezConfiguration.TEZ_AM_VERTEX_CLEANUP_HEIGHT_DEFAULT) > 0 &&
ShuffleUtils.isTezShuffleHandler(dag.dagConf);
+ if (cleanupShuffleDataAtVertexLevel) {
+ int deletionHeight =
dag.dagConf.getInt(TezConfiguration.TEZ_AM_VERTEX_CLEANUP_HEIGHT,
+ TezConfiguration.TEZ_AM_VERTEX_CLEANUP_HEIGHT_DEFAULT);
+
+ VertexShuffleDataDeletionContext vShuffleDeletionContext =
Review comment:
what about putting all this to VertexImpl, like:
```
vertex.initShuffleDeletionContext(deletionHeight)
```
?
that way you don't have to expose the init logic to DagImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
