abstractdog commented on code in PR #209:
URL: https://github.com/apache/tez/pull/209#discussion_r867321061
##########
tez-api/src/main/java/org/apache/tez/common/TezCommonUtils.java:
##########
@@ -291,7 +291,14 @@ public static Path getSummaryRecoveryPath(Path
attemptRecoverPath) {
* @throws IOException
*/
public static void mkDirForAM(FileSystem fs, Path dir) throws IOException {
- fs.mkdirs(dir, new FsPermission(TEZ_AM_DIR_PERMISSION));
+ FsPermission perm = new FsPermission(TEZ_AM_DIR_PERMISSION);
+ fs.mkdirs(dir, perm);
+ if(!fs.getFileStatus(dir).getPermission().equals(perm)){
Review Comment:
this method is public static, looks easily testable, could you please
introduce a unit test in TestTezCommonUtils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
