[
https://issues.apache.org/jira/browse/TEZ-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4432:
------------------------------
Description:
After TEZ-3918, which removed most of the method body, only a null check can be
found.
{code}
static void maybeAddDefaultLoggingJavaOpts(String logLevel, List<String>
vargs) {
Objects.requireNonNull(vargs);
TezClientUtils.addLog4jSystemProperties(logLevel, vargs);
}
{code}
I believe this method should be removed and Objects.requireNonNull should be
moved to addLog4jSystemProperties
> Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils
> -----------------------------------------------------------------
>
> Key: TEZ-4432
> URL: https://issues.apache.org/jira/browse/TEZ-4432
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> After TEZ-3918, which removed most of the method body, only a null check can
> be found.
> {code}
> static void maybeAddDefaultLoggingJavaOpts(String logLevel, List<String>
> vargs) {
> Objects.requireNonNull(vargs);
> TezClientUtils.addLog4jSystemProperties(logLevel, vargs);
> }
> {code}
> I believe this method should be removed and Objects.requireNonNull should be
> moved to addLog4jSystemProperties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
