abstractdog commented on code in PR #236:
URL: https://github.com/apache/tez/pull/236#discussion_r950103160
##########
tez-dag/src/main/java/org/apache/tez/dag/app/rm/TaskSchedulerManager.java:
##########
@@ -910,7 +910,8 @@ public void reportError(int taskSchedulerIndex,
ServicePluginError servicePlugin
LOG.info("Error reported by scheduler {} - {}",
Utils.getTaskSchedulerIdentifierString(taskSchedulerIndex,
appContext) + ": " +
diagnostics);
- if
(taskSchedulerDescriptors[taskSchedulerIndex].getClassName().equals(yarnSchedulerClassName))
{
+ if (taskSchedulerDescriptors[taskSchedulerIndex].getEntityName()
Review Comment:
I see, nice catch:
https://github.com/apache/tez/blob/621a83152c305ccb654f69f57fe711bc52d271be/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L2676
we simply don't fill the classname, so we should not rely on it, only use it
in case of createCustomTaskScheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
