abstractdog commented on code in PR #169:
URL: https://github.com/apache/tez/pull/169#discussion_r1024987570
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/Fetcher.java:
##########
@@ -544,8 +545,8 @@ private HostFetchResult
setupConnection(Collection<InputAttemptIdentifier> attem
} else {
InputAttemptIdentifier firstAttempt = attempts.iterator().next();
LOG.warn(String.format(
- "Fetch Failure while connecting from %s to: %s:%d, attempt: %s
Informing ShuffleManager: ",
- localHostname, host, port, firstAttempt), e);
+ "Fetch Failure while connecting from %s to: %s:%d, attempt: %s,
url: %s Informing ShuffleManager",
+ localHostname, host, port, firstAttempt, baseURI.toString()), e);
Review Comment:
using {} format would make sense but we cannot mix the format arguments and
exception in any of the LOG.warn methods
toString can be removed yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
