abstractdog commented on code in PR #263:
URL: https://github.com/apache/tez/pull/263#discussion_r1102587503
##########
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java:
##########
@@ -102,6 +103,20 @@ public abstract class TezSplitGrouper {
public static final String TEZ_GROUPING_NODE_LOCAL_ONLY =
"tez.grouping.node.local.only";
public static final boolean TEZ_GROUPING_NODE_LOCAL_ONLY_DEFAULT = false;
+ /**
+ * Number of threads used to initialize the grouped splits, to
asynchronously open the readers.
+ */
+ public static final String TEZ_GROUPING_SPLIT_INIT_THREADS =
"tez.grouping.split.init-threads";
+ public static final int TEZ_GROUPING_SPLIT_INIT_THREADS_DEFAULT = 4;
+
+ /**
+ * Number of record readers to asynchronously and proactively init.
+ * Inorder for upstream apps to use this feature, The objects created in the
Review Comment:
thanks, this makes sense, only minor typos:
"In order", "the objects"
LGTM, let me finish fixing precommit in
[TEZ-4471](https://issues.apache.org/jira/browse/TEZ-4471) and then I'll let
you know to restart precommit on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
