shameersss1 commented on code in PR #257:
URL: https://github.com/apache/tez/pull/257#discussion_r1107153392
##########
tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java:
##########
@@ -306,21 +305,24 @@ public ReduceMapFileCount(ReduceContext rc) {
@Override
public void operationComplete(ChannelFuture future) throws Exception {
+ Channel ch = future.channel();
if (!future.isSuccess()) {
- future.channel().close();
+ ch.close();
return;
}
int waitCount = this.reduceContext.getMapsToWait().decrementAndGet();
if (waitCount == 0) {
+ LOG.debug("Finished with all map outputs");
+ ch.writeAndFlush(LastHttpContent.EMPTY_LAST_CONTENT);
Review Comment:
can we add comment why this is required here.
##########
tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java:
##########
@@ -306,21 +305,24 @@ public ReduceMapFileCount(ReduceContext rc) {
@Override
public void operationComplete(ChannelFuture future) throws Exception {
+ Channel ch = future.channel();
if (!future.isSuccess()) {
- future.channel().close();
+ ch.close();
return;
}
int waitCount = this.reduceContext.getMapsToWait().decrementAndGet();
if (waitCount == 0) {
+ LOG.debug("Finished with all map outputs");
Review Comment:
Since this is in the hotpath should be enclose this in
`if (LOG.isDebugEnabled()) {
}` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
